Include expiration entry on ledger entries in getContractData/getLedgerEntries responses #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaptic
reviewed
Oct 10, 2023
sreuland
commented
Oct 10, 2023
@Shaptic , I've responded to feedback, all commits in, lmk, thanks! |
Shaptic
reviewed
Oct 10, 2023
Shaptic
reviewed
Oct 11, 2023
Shaptic
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a client-side approach to eagerly fetching the ledger entry expiration info(ExpirationEntry) automatically for any
LedgerDataEntryrequested through getLedgerEntries and getContractData, and then it embeds the ExpirationEntry found asexpirationon each response item built from the LedgerDataEntry.it's meant as interim solution until stellar/stellar-cli#1010 modifes the rpc server to include expiration entry info by default on ledger data entries in rpc responses.
Closes #153