Check fee values against "undefined" (#241)

Check fee values against "undefined"
stellar · May 25, 2021 · a847eb2 · a847eb2
1 parent edb232d
commit a847eb2
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
 ## In master
 
+## [v0.3.0-rc.9](https://github.com/stellar/js-stellar-wallets/compare/v0.3.0-rc.8...v0.3.0-rc.9)
+
+- Fix issue where zero fees were still being considered as "complex"
+  instead of "simple".
+
 ## [v0.3.0-rc.8](https://github.com/stellar/js-stellar-wallets/compare/v0.3.0-rc.7...v0.3.0-rc.8)
 
 - Also consider 0 (zero) as "simple" fee type when parsing asset info.

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@stellar/wallet-sdk",
-  "version": "0.3.0-rc.8",
+  "version": "0.3.0-rc.9",
   "description": "Libraries to help you write Stellar-enabled wallets in Javascript",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

diff --git a/src/transfers/parseInfo.ts b/src/transfers/parseInfo.ts
@@ -41,8 +41,8 @@ const parseFee = (
   feeEnabled: boolean,
 ): Fee => {
   if (
-    (fee_fixed && Number(fee_fixed) >= 0) ||
-    (fee_percent && Number(fee_percent) >= 0)
+    (fee_fixed !== undefined && Number(fee_fixed) >= 0) ||
+    (fee_percent !== undefined && Number(fee_percent) >= 0)
   ) {
     return {
       type: "simple",