Update stellar-sdk import in claimantHelpers.js #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyalbasu
approved these changes
Dec 18, 2023
|
@Row-Bear Sorry for the late review - but thank you for catching this! I'm going to add this to the next release |
piyalbasu
added a commit
that referenced
this pull request
Dec 19, 2023
* Update stellar-sdk import in claimantHelpers.js (#723) Co-authored-by: Piyal Basu <[email protected]> * upgrade stellar-sdk (#734) * upgrade stellar-sdk * update yarn lock --------- Co-authored-by: Row-Bear <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Create Claimable Balance operation fails to generate an XDR if a predicate is used, instead reporting
"- Operation #1: o.a is undefined "
I believe that is due to the import of stellar-sdk, which was updated recently for other parts