Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Account] Adding routes #771

Merged
merged 8 commits into from
Mar 6, 2024
Merged

[Account] Adding routes #771

merged 8 commits into from
Mar 6, 2024

Conversation

jeesunikim
Copy link
Contributor

Summary:

  • Adding routes

jeesunikim
jeesunikim commented Mar 5, 2024
View reviewed changes
src/styles/globals.scss Outdated Show resolved Hide resolved
@stellar-jenkins
Copy link

Preview is available here:
http://laboratory-pr771.previews.kube001.services.stellar-ops.com/

quietbits
quietbits reviewed Mar 5, 2024
View reviewed changes
src/styles/globals.scss Outdated Show resolved Hide resolved
@stellar-jenkins
Copy link

Preview is available here:
http://laboratory-pr771.previews.kube001.services.stellar-ops.com/

3 similar comments
@stellar-jenkins
Copy link

Preview is available here:
http://laboratory-pr771.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

Preview is available here:
http://laboratory-pr771.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

Preview is available here:
http://laboratory-pr771.previews.kube001.services.stellar-ops.com/

@jeesunikim jeesunikim changed the title Account > Routes [Account] Adding routes Mar 5, 2024
quietbits
quietbits approved these changes Mar 6, 2024
View reviewed changes
src/app/(sidebar)/account/create/page.tsx Outdated Show resolved Hide resolved
src/app/(sidebar)/account/styles.scss Outdated Show resolved Hide resolved
src/constants/routes.ts
Comment on lines +4 to +7
ACCOUNT_CREATE = "/account/create",
ACCOUNT_FUND = "/account/fund",
ACCOUNT_CREATE_MUXED = "/account/muxed-create",
ACCOUNT_PARSE_MUXED = "/account/muxed-parse",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for renaming these! Reads better now. 🎉

@stellar-jenkins
Copy link

Preview is available here:
http://laboratory-pr771.previews.kube001.services.stellar-ops.com/

1 similar comment
@stellar-jenkins
Copy link

Preview is available here:
http://laboratory-pr771.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

Preview is available here:
http://laboratory-pr771.previews.kube001.services.stellar-ops.com/

@jeesunikim jeesunikim merged commit 6c4615a into laboratory-v2 Mar 6, 2024
3 checks passed
@jeesunikim jeesunikim linked an issue Mar 6, 2024 that may be closed by this pull request
[Account] Adding routes #775
Closed
1 task
@quietbits quietbits deleted the account-routes branch August 22, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quietbits quietbits quietbits approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Account] Adding routes
3 participants
@jeesunikim @stellar-jenkins @quietbits