Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default Captive Core Horizon configuration #144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Shaptic
Copy link

@Shaptic Shaptic commented Jun 11, 2021

  • As of v2.1, we don't need the TMPDIR workaround and should prefer setting --captive-core-storage-path.
  • We also do more validation on the input TOML for --captive-core-config-path, and we should point it to an actual Captive Core config rather than the full Stellar Core config

 - As of v2.1, we don't need the `TMPDIR` workaround and should prefer setting
   `--captive-core-storage-path`.
 - We also do more validation on the input TOML for
   `--captive-core-config-path`, and we should point it to an actual Captive
   Core config rather than the full Stellar Core config
Copy link
Contributor

@jacekn jacekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants