Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable soroban diagnostic events by default #474

Closed
sreuland opened this issue Jul 26, 2023 · 6 comments · Fixed by #510
Closed

enable soroban diagnostic events by default #474

sreuland opened this issue Jul 26, 2023 · 6 comments · Fixed by #510
Labels
stale

Comments

@sreuland
Copy link
Contributor

What problem does your feature solve?

currently, soroban diagnostic events are not enabled by default, you have to include --enable-soroban-diagnostic-events

What would you like to see?

make soroban diagnostic events enabled by default when using --enable-soroban-rpc. remove --enable-soroban-diagnostic-events

What alternatives are there?
@tomerweller
Copy link

Related stellar/stellar-cli#806

@leighmcculloch
Copy link
Member

+1 Enabling diagnostic events by default sits well with this image being intended for development and testing.

@github-actions
Copy link

This issue is stale because it has been open for 30 days with no activity. It will be closed in 30 days unless the stale label is removed.

@github-actions github-actions bot added the stale label Sep 23, 2023
@leighmcculloch
Copy link
Member

We did this for local:

@leighmcculloch leighmcculloch mentioned this issue Oct 23, 2023
Merged
@leighmcculloch leighmcculloch reopened this Apr 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2024

This issue is stale because it has been open for 30 days with no activity. It will be closed in 30 days unless the stale label is removed.

@github-actions github-actions bot added the stale label May 5, 2024
@sreuland
Copy link
Contributor Author

sreuland commented May 6, 2024

thttps://github.com//pull/510 resolves this issue, it enables diag events by default on local network, closing.

@sreuland sreuland closed this as completed May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Always enable Soroban diagnostic events on local stellar/quickstart
3 participants
@leighmcculloch @tomerweller @sreuland