Always enable Soroban diagnostic events on local #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Always enable Soroban diagnostic events on local, unless explicitly disabled.
Why
Most of the time when folks are using quickstart in local mode they're developing locally or running quickstart in CI. In these modes diagnostic events are critical for understanding what's happening when things go wrong, and debugging during testing and development.
Much like how we enable other test capabilities in local, we should enable diagnostics because that's the most sensible default for developing in local.
We shouldn't change the default for testnet/pubnet, because diagnostics cause unmetered execution and on testnet/pubnet there's no guarantee other peoples contracts being executed would not cause unreasonable resource consumption.
The addition of the ability to disable on local is so that the Digital Ocean template can turn it off since that is a deployed local instance.
Close #474