Delay capturing logs from services and the start script until after the setup is complete #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
changed the title
sreuland
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Delay capturing logs from services and the start script until after the setup is complete.
Why
When starting the container without the
--logsoption, a set of output is seen that shows what the network is, that a password needs entering for persistent mode, etc.When starting the container with the
--logsoption, those startup logs get funneled into the log output and get mixed up with a heap of stellar-core logs.What's worse is the persistent mode postgres read password from stdin functionality doesn't work properly with
--logsand causes problems as the prompt isn't rendered before the STDIN is waited on.The startup output doesn't need to be captured into the log output. We can delay when we start the log output until after the startup output is complete.
Close #464