Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated core ref on build-soroban-dev target #491

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

sreuland
Copy link
Contributor

@sreuland sreuland commented Sep 15, 2023

consistent ref to the v20.0.0rc1 tag for core, used commit hash setting on earlier pr - #483

@leighmcculloch
Copy link
Member

This change seems unnecessary given:
https://github.com/stellar/stellar-core/releases/tag/v20.0.0rc1

@sreuland
Copy link
Contributor Author

This change seems unnecessary given: https://github.com/stellar/stellar-core/releases/tag/v20.0.0rc1

yes, I reverted, and used as opportunity to make consist the ref to tag elsewhere.

@leighmcculloch leighmcculloch merged commit f19b628 into master Sep 15, 2023
62 checks passed
@leighmcculloch leighmcculloch deleted the update_core_ref_make branch September 15, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants