Set TESTING_SOROBAN_HIGH_LIMIT_OVERRIDE for standalone network #492
Conversation
|
Unfortunately because the ingest package used by rpc and horizon is very opinionated about what are valid stellar-core.cfg parameters, we can't use this change on pubnet version of horizon that this image works with. The parameters in the cfg have to be supported by: So we need to injest this value into the cfg's depending on the version of horizon and rpc in use. I think that's why the pubnet variation of the tests are failing, because it's using a version of ingest that doesn't yet support the parameter. |
|
I think we can add to start script a check if horizon version is greater than N, inject the param. And for rpc we can have it always be set. |
leighmcculloch
changed the title
| @@ -361,6 +362,12 @@ function init_stellar_core() { | |||
| run_silent "finalize-core-config-run-local" perl -pi -e "s/__RUN_STANDALONE__/$RUN_STANDALONE/g" etc/stellar-core.cfg | |||
| run_silent "finalize-core-config-manual-close" perl -pi -e "s/__MANUAL_CLOSE__/$ENABLE_CORE_MANUAL_CLOSE/g" etc/stellar-core.cfg | |||
|
|
|||
| if [ "$NETWORK" = "standalone" ] && [ "${CORE_SUPPORTS_TESTING_SOROBAN_HIGH_LIMIT_OVERRIDE}" = "true" ]; then | |||
There was a problem hiding this comment.
should this be checking for NETWORK=local now?
What ?
Following a conversation with @leighmcculloch , we've decided to drop PR #480, and just set the TESTING_SOROBAN_HIGH_LIMIT_OVERRIDE for standalone networks.
The limits currently being set cannot be adjusted anyway, and it's less than likely that any developer would want to disable that on standalone network.