Test horizon captive-core with soroban-rpc #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sreuland
approved these changes
Sep 20, 2023
leighmcculloch
deleted the
test-horizon-captive-core-with-soroban-rpc
branch
Testnet is enabled at protocol version 20, but there were some issues during the upgrade and I think it had affected the test runs that used testnet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Enable horizon captive-core when testing soroban-rpc.
Why
To test that both run side-by-side well.
In #497 we discovered the test matrix we are running has a gap that doesn't test horizon with captive-core alongside soroban-rpc. There's little value of running tests with only one or the other enabled. Running a test with both is more useful in identifying problems with them interacting.
In the future we will do #498.