-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give images pushed by CI version numbers #549
Conversation
I'd like to rename the yml files so they more clearly communicate the intent, but to do so would make this diff much larger. So I'm leaving them as they are. The way the files are related is:
|
I placed the version number at the front of labels, i.e. |
what do you think about generating version tags, but not on pr's or merge of master, rather generate version tags only on repo tag events and pull the gh tag name to use when publish the docker tag such as |
That's an option, and was approximately what I was suggesting here #530 (comment). But it would increase the maintenance burden on a repo that we try to be very minimal about. It'd also result in some variants probably falling behind on features than other variants. |
What
Give images pushed by CI version numbers.
Each commit on the
master
branch that publishes to DockerHub will be given a version number with the number based on the number of commits on the master branch.Each commit on a pull request branch that publishes will be given a version number also based on the number of commits.
E.g. for commit 300, the version number will be v300, and the labels for the commit published will be
:v300-latest
,:v300-testing
,:v300-future
.For example, for PR 23, with commit number 200, the labels will be
:pr23-v200-latest
, etc.The
:latest
,:testing
,:future
labels are also aliased to the version when published from master, and:pr-23-latest
, etc when published from a pr.Why
Make it easier to reference specific versions of the image.
At the moment folks have to dig up digests, which is fine, but it's much easier to be able to tell people "use v353 of the image."
The versioning isn't really necessary on PRs, but it was easier to make the master branch and PR branches work the same than it would be to make them work differently.
Implementation Details
The change involved moving the three image variant builds that run independently as their own workflows, under a single workflow that triggers them. This has some side-effects: