Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump testing and future to v22.0.0rc2 #631

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

sisuresh
Copy link
Contributor

@sisuresh sisuresh commented Oct 8, 2024

No description provided.

Makefile Outdated Show resolved Hide resolved
@leighmcculloch leighmcculloch enabled auto-merge (squash) October 8, 2024 23:19
@willemneal
Copy link
Member

willemneal commented Oct 9, 2024

Shouldn't the protocol version be bumped to 22?

@willemneal
Copy link
Member

And don't we need to update soroban-rpc?

@sisuresh
Copy link
Contributor Author

sisuresh commented Oct 9, 2024

And don't we need to update soroban-rpc?

We do, but soroban-rpc hasn't been released yet.

Shouldn't the protocol version be bumped to 22?

We have to keep it at 21 for now until the soroban-rpc and horizon releases are ready.

@willemneal
Copy link
Member

How can I use the unreleased versions? Can we use a prerelease?

@leighmcculloch
Copy link
Member

A couple of the core builds keep failing, but the errors aren't outputted or obvious. When I test the same build locally it works fine. And after rerunning a few times one of the failures started passing, so I'll keep doing same for the moment. It's only happening on arm64 builds, and arm64 builds are intensive due to emulation, so maybe we're killing / losing the instances due to some sort of overuse.

I've got another PR in process that gets us away from using emulation for arm64 builds, I might get time to close that out and maybe that'll make the arm64 builds more reliable:

@leighmcculloch
Copy link
Member

How can I use the unreleased versions? Can we use a prerelease?

@willemneal Once we get this build passing you could use the image here, but it still won't have the RPC. Once this PR merges we'll get the RPC updated in a PR and you will hopefully be able to use it straight away.

@leighmcculloch leighmcculloch merged commit a7d6714 into stellar:master Oct 10, 2024
153 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants