Require PROTOCOL_VERSION_DEFAULT #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
approved these changes
Dec 17, 2024
leighmcculloch
commented
Dec 17, 2024
leighmcculloch
commented
Dec 17, 2024
leighmcculloch
commented
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Error during image build if the
PROTOCOL_VERSION_DEFAULTvariable is not set.Why
Images won't reliably work unless the arg is set. The image does fall back to whatever core's max supported protocol version, but we moved away from that a while ago and missed removing that check. The reason we don't rely on that anymore is that core's max supported version is not representative of the entire images max supported version because the image runs multiple software and it's common for core to release a new version before other software.