Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

host: fix EXPIRATION_ENTRY_SIZE constant #1034

Merged
merged 3 commits into from
Sep 5, 2023

Conversation

2opremio
Copy link
Contributor

@2opremio 2opremio commented Sep 4, 2023

It didn't account for the size of the ledger entry type and modifiedLedgerSequence field

See stellar/stellar-cli#922 (comment) for more details

@2opremio
Copy link
Contributor Author

2opremio commented Sep 4, 2023

@sisuresh can you take a look and also update the SDK when merged?

@2opremio 2opremio force-pushed the fix-expiration-entry-size branch from d6c748e to d4b15ce Compare September 5, 2023 00:55
Copy link
Contributor

@sisuresh sisuresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch. Thanks for the fix and the test.

@sisuresh sisuresh added this pull request to the merge queue Sep 5, 2023
Merged via the queue into stellar:main with commit 3d6c35d Sep 5, 2023
9 checks passed
github-merge-queue bot pushed a commit to stellar/rs-soroban-sdk that referenced this pull request Sep 5, 2023
@2opremio 2opremio deleted the fix-expiration-entry-size branch September 5, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants