Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rent changes extraction bug #1043

Merged
merged 6 commits into from
Sep 8, 2023
Merged

Fix rent changes extraction bug #1043

merged 6 commits into from
Sep 8, 2023

Conversation

jayz22
Copy link
Contributor

@jayz22 jayz22 commented Sep 6, 2023

What

Resolves #1037

  • Fix rent extraction -- do not skip entry if the entry size has increased
  • Adds a function in the storage contract to facilitate core testing

Why

[TODO: Why this change is being made. Include any context required to understand the why.]

Known limitations

[TODO or N/A]

@jayz22 jayz22 changed the title [WIP] fix rent charge and add test contract Fix rent changes extraction bug Sep 6, 2023
@jayz22 jayz22 marked this pull request as ready for review September 6, 2023 22:14
@jayz22 jayz22 requested review from graydon, sisuresh and a team as code owners September 6, 2023 22:14
@jayz22 jayz22 requested a review from SirTyson September 6, 2023 22:14
@sisuresh sisuresh added this pull request to the merge queue Sep 8, 2023
Merged via the queue into stellar:main with commit 880afe7 Sep 8, 2023
9 checks passed
@jayz22 jayz22 deleted the fix-fee branch September 10, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to charge rent when contract data entry is updated to take extra storage space
2 participants