Code

Graydon code review#1044

Code

Merged

leighmcculloch merged 11 commits intomainstellar/rs-soroban-env:mainfrom graydon-code-reviewstellar/rs-soroban-env:graydon-code-reviewCopy head branch name to clipboardSep 8, 2023

+331-231

Commits

Commits on Sep 7, 2023

• fix bad names

  graydon

  committed
  a885d58

• Move code in host to match env.json and add region markers

  graydon

  committed
  164d403

Commits on Sep 8, 2023

• Make Env::Error: Into<crate::Error>, use for errors in bytes.rs

  graydon

  committed
  7675c81

• Remove a duplicate compare and a panic from compare.rs

  graydon

  committed
  4f2a9d5

• Add comments to TryFromVal and TryIntoVal

  graydon

  committed
  85fba22

• Change some ConversionErrors to Errors

  graydon

  committed
  950750d

• Change more ConversionErrors, these need (minor) SDK changes

  graydon

  committed
  78fd4d1

• Change more ConversionErrors to Errors

  graydon

  committed
  8902da8

• Change ConversionErrors to passed-throgh Errors on Result<T,E>

  graydon

  committed
  e7cedc7

• Change ConversionErrors to passed-throgh Errors on (T,U,...) tuples

  graydon

  committed
  c191fe4

• Remove more instances of ConversionError (symbol)

  graydon

  committed
  c858d50