Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to rs-stellar-xdr Limits change #1139

Merged
merged 11 commits into from
Nov 10, 2023
Merged

Adapt to rs-stellar-xdr Limits change #1139

merged 11 commits into from
Nov 10, 2023

Conversation

jayz22
Copy link
Contributor

@jayz22 jayz22 commented Oct 28, 2023

What

  • Adapts to Update xdrgen rs-stellar-xdr#317 and runs perf analysis.
  • Make DepthLimiter internal (the depth limiting mechanism for the host stays the same)
  • Defines the default XDR read/write limits (depth, length).

Why

[TODO: Why this change is being made. Include any context required to understand the why.]

Known limitations

[TODO or N/A]

@jayz22 jayz22 changed the title Cali Run calibration for bytes array deserialization Oct 28, 2023
@jayz22 jayz22 changed the title Run calibration for bytes array deserialization Adapt to rs-stellar-xdr Limits change Nov 8, 2023
@jayz22 jayz22 marked this pull request as ready for review November 8, 2023 02:04
@jayz22 jayz22 requested review from graydon, sisuresh and a team as code owners November 8, 2023 02:04
@graydon graydon enabled auto-merge November 9, 2023 19:09
@graydon graydon added this pull request to the merge queue Nov 9, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 9, 2023
@graydon graydon enabled auto-merge November 9, 2023 21:26
@graydon graydon added this pull request to the merge queue Nov 9, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 9, 2023
@graydon graydon enabled auto-merge November 9, 2023 23:12
auto-merge was automatically disabled November 9, 2023 23:45

Head branch was pushed to by a user without write access

@graydon graydon enabled auto-merge November 9, 2023 23:54
@graydon graydon added this pull request to the merge queue Nov 10, 2023
Merged via the queue into stellar:main with commit dfceb3d Nov 10, 2023
@jayz22 jayz22 deleted the cali branch December 13, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants