Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

20.1.0 cleanup #1314

Merged
merged 12 commits into from
Jan 9, 2024
Merged

20.1.0 cleanup #1314

merged 12 commits into from
Jan 9, 2024

Conversation

dmkozh
Copy link
Contributor

@dmkozh dmkozh commented Jan 5, 2024

No description provided.

leighmcculloch
leighmcculloch reviewed Jan 5, 2024
View reviewed changes
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pursuing this. I think the internal cleanup of char -> u8 makes it a bit easier for me to understand the intent and so I think it's worthwhile. Some questions and comments inline.

soroban-env-common/src/symbol.rs Show resolved Hide resolved
soroban-env-common/src/symbol.rs Outdated Show resolved Hide resolved
soroban-env-common/src/symbol.rs Show resolved Hide resolved
soroban-env-common/src/val.rs Outdated Show resolved Hide resolved
soroban-env-host/src/host.rs Outdated Show resolved Hide resolved
soroban-env-host/src/host/conversion.rs Show resolved Hide resolved
soroban-env-common/src/symbol.rs Outdated Show resolved Hide resolved
soroban-env-common/src/val.rs Outdated Show resolved Hide resolved
@dmkozh dmkozh marked this pull request as ready for review January 8, 2024 22:30
@dmkozh dmkozh requested review from graydon and a team as code owners January 8, 2024 22:30
graydon
graydon requested changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@graydon graydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small number of nits / comment requests, basically looks ok.

soroban-env-host/src/host/conversion.rs Show resolved Hide resolved
soroban-env-host/src/host/conversion.rs Show resolved Hide resolved
soroban-env-macros/src/synth_linear_memory_tests.rs Show resolved Hide resolved
@graydon graydon added this pull request to the merge queue Jan 8, 2024
Merged via the queue into stellar:main with commit c1b238b Jan 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sisuresh sisuresh sisuresh left review comments

@leighmcculloch leighmcculloch leighmcculloch left review comments

@graydon graydon graydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmkozh @graydon @leighmcculloch @sisuresh