Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing #1324

Merged
merged 14 commits into from
Jan 17, 2024
Merged

Tracing #1324

merged 14 commits into from
Jan 17, 2024

Conversation

graydon
Copy link
Contributor

@graydon graydon commented Jan 12, 2024

This PR splits the existing "observation" machinery out into a separate "tracing" subsystem that uses the shadow budget to reduce DoS risk if it's ever activated in production. It therefore includes a (manual, awful) metered hash implementation of everything that gets hashed in that machinery. It also includes some reorganization of the code and general reduction of unnecessary allocations.

There'll be a corresponding change to core to route this tracing output into the core logging system. There are maybe a couple things left to clean up tomorrow but it's good enough to be reviewed now:

  • Remove the json observation files for the tests un-observed
  • Maybe add an EnvBase::tracing_enabled() -> bool that we can use to short-circuit composing the arg arrays in general

@graydon graydon force-pushed the bug-3980-trace-logging branch from 91d2180 to 42d0809 Compare January 15, 2024 19:37
@graydon graydon force-pushed the bug-3980-trace-logging branch from e91a83c to db5819b Compare January 16, 2024 22:59
@graydon graydon added this pull request to the merge queue Jan 17, 2024
Merged via the queue into stellar:main with commit b6ef8e3 Jan 17, 2024
13 checks passed
@graydon graydon deleted the bug-3980-trace-logging branch January 17, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants