Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1283 asset code rendering #1336

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Bug 1283 asset code rendering #1336

merged 3 commits into from
Jan 30, 2024

Conversation

graydon
Copy link
Contributor

@graydon graydon commented Jan 30, 2024

Fixes #1283 by reusing the rendered asset code prefix of metadata.name for metadata.symbol

Unfortunately creates a new host object during SAC init, which requires re-observing basically all the SAC tests.

@graydon
Copy link
Contributor Author

graydon commented Jan 30, 2024

(Note the other option -- trimming asset_info.asset_code and re-padding it when converting to XDR -- would probably cause a little less churn in the testsuite due to not having to make a new object; but it would still perturb a bit due to the hash of storage and the host object repertoire changing. Not sure if it matters, but I'm willing to try that variant too?)

@graydon graydon added this pull request to the merge queue Jan 30, 2024
Merged via the queue into main with commit 89f8123 Jan 30, 2024
13 checks passed
@graydon graydon deleted the bug-1283-asset-code-rendering branch January 30, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asset codes are stored in strings with trailing zeros
3 participants