P22 with wasmi reverted to 031 #1460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I did a bit of research and figured out that this is fine. In p21 we didn't build module cache for create_contract operation because we didn't instantiate VM. In p22 we do that to support constructors, but the error has been avoided due to lazy Wasmi compilation mode used by the module cache (as opposed to the eager mode on upload). Thus the test failing is expected for the old Wasmi as it doesn't have a lazy mode. |
graydon
force-pushed
the
p22-with-wasmi-reverted-to-031
branch
from
81f61e5 to
4d1f8d8
Compare
sisuresh
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts wasmi from 0.36 to 0.31 while retaining everything else that's happened in p22. In particular the host still only speaks p22 and refuses to emulate p21.