Small optimizations for Symbol. #1520
Open
+95
−128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use `Symbol::try_from_val` in `map_new_from_linear_memory` which both ensures the proper symbol validation and makes the conversion slightly cheaper - Convert slices to symbols based on their length instead of re-trying the conversion for both lengths. This is really tiny performance-wise, but makes the code simpler to maintain by reducing the risk of accidentally creating a symbol with incorrect length Both are non-functional protocol changes: while they have to go into env for the new protocol, the only observable change is the slight reduction of CPU costs. nju
dmkozh
force-pushed
the
symbol_bug_fix
branch
from
5d5c1b0 to
cfe5658
Compare
There was a problem hiding this comment.
Previous attempts to optimise Symbol code have caused significant changes guest side that was unintuitive and unexpected.
Does this function ever get triggered contract side? If yes, what impact does this have on WASM size and instructions this translates into on the contract side?
Although, I expect and hope this function doesn't get called contract side because doing so would embed Symbol encoding logic into contracts.
On the surface this looks fine to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Symbol::try_from_valinmap_new_from_linear_memorywhich both ensures the proper symbol validation (which doesn't happen now) and makes the conversion slightly cheaperBoth are non-functional protocol changes: while they have to go into env for the new protocol, the only observable change is the slight reduction of CPU costs.
Why
Implementation cleanup/optimization
Known limitations
N/A