Skip to content

Commit

Permalink
Reduce false positives in rust-analyzer compat ci check (#994)
Browse files Browse the repository at this point in the history
### What
Only consider lines output from rust-analyzer as an error if they begin
with `[ERROR`.

### Why
We've started to see some false positives where the word ERROR appears
in non-error output.
  • Loading branch information
leighmcculloch authored Jun 20, 2023
1 parent 56bf975 commit 72af4ee
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@ jobs:
steps:
- uses: actions/checkout@v3
- run: rustup update
- run: rustup +nightly component add rust-analyzer
- run: rustup component add rust-analyzer
- name: Check if rust-analyzer encounters any errors parsing project
run: rustup run nightly rust-analyzer analysis-stats . 2>&1 | (! grep ERROR)
run: rustup run stable rust-analyzer analysis-stats . 2>&1 | (! grep '^\[ERROR')

build-and-test:
strategy:
Expand Down

0 comments on commit 72af4ee

Please sign in to comment.