Run CI for the msrv and latest rust version (#1205)

### What Build and test the MSRV and latest ### Why For stellar/rs-soroban-env#1311
stellar · Jan 10, 2024 · 9f955ef · 9f955ef
1 parent 811ce3d
commit 9f955ef
Show file tree

Hide file tree

Showing 27 changed files with 40 additions and 40 deletions.
diff --git a/.github/workflows/rust-version.yml b/.github/workflows/rust-version.yml
diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
@@ -6,9 +6,6 @@ on:
   pull_request:
   merge_group:
 
-env:
-  RUSTFLAGS: -D warnings
-
 defaults:
   run:
     shell: bash
@@ -64,6 +61,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
+        rust: [msrv, latest]
         sys:
         - os: ubuntu-latest
           target: x86_64-unknown-linux-gnu
@@ -85,15 +83,27 @@ jobs:
     steps:
     - uses: actions/checkout@v3
     - uses: stellar/actions/rust-cache@main
+    - name: Use the minimum supported Rust version
+      if: matrix.rust == 'msrv'
+      run: |
+        msrv="$(cargo metadata --format-version 1 --no-deps | jq -r '.packages | map(.rust_version) | map(values) | min')"
+        rustup override set $msrv
+        rustup component add clippy --toolchain $msrv
+    - name: Error on warnings and clippy checks
+      # Only error on warnings and checks for the msrv, because new versions of
+      # Rust will frequently add new warnings and checks.
+      if: matrix.rust == 'msrv'
+      run: echo RUSTFLAGS='-Dwarnings' >> $GITHUB_ENV
     - run: rustup update
+    - run: cargo version
     - run: rustup target add ${{ matrix.sys.target }}
     - run: rustup target add wasm32-unknown-unknown
     - if: matrix.target == 'aarch64-unknown-linux-gnu'
       run: sudo apt-get update && sudo apt-get -y install gcc-aarch64-linux-gnu g++-aarch64-linux-gnu
-    - uses: stellar/binaries@v12
+    - uses: stellar/binaries@v18
       with:
         name: cargo-hack
-        version: 0.5.16
+        version: 0.5.28
     - if: startsWith(matrix.sys.target, 'x86_64')
       name: Clear test snapshots for checking no diffs exists after test run
       run: rm -fr **/test_snapshots

diff --git a/Cargo.toml b/Cargo.toml
@@ -30,6 +30,7 @@ members = [
 
 [workspace.package]
 version = "20.1.0"
+rust-version = "1.74.0"
 
 [workspace.dependencies]
 soroban-sdk = { version = "20.1.0", path = "soroban-sdk" }

diff --git a/soroban-ledger-snapshot/Cargo.toml b/soroban-ledger-snapshot/Cargo.toml
@@ -8,7 +8,7 @@ readme = "../README.md"
 license = "Apache-2.0"
 version.workspace = true
 edition = "2021"
-rust-version = "1.74"
+rust-version.workspace = true
 
 [dependencies]
 soroban-env-host = { workspace = true }

diff --git a/soroban-sdk-macros/Cargo.toml b/soroban-sdk-macros/Cargo.toml
@@ -8,7 +8,7 @@ readme = "../README.md"
 license = "Apache-2.0"
 version.workspace = true
 edition = "2021"
-rust-version = "1.74"
+rust-version.workspace = true
 
 [lib]
 proc-macro = true

diff --git a/soroban-sdk/Cargo.toml b/soroban-sdk/Cargo.toml
@@ -8,7 +8,7 @@ readme = "README.md"
 license = "Apache-2.0"
 version.workspace = true
 edition = "2021"
-rust-version = "1.74"
+rust-version.workspace = true
 
 exclude = ["test_snapshots/", "src/tests/"]
 

diff --git a/soroban-spec-rust/Cargo.toml b/soroban-spec-rust/Cargo.toml
@@ -8,7 +8,7 @@ readme = "../README.md"
 license = "Apache-2.0"
 version.workspace = true
 edition = "2021"
-rust-version = "1.74"
+rust-version.workspace = true
 
 [dependencies]
 stellar-xdr = { workspace = true, features = ["curr", "std", "serde"] }

diff --git a/soroban-spec/Cargo.toml b/soroban-spec/Cargo.toml
@@ -8,7 +8,7 @@ readme = "../README.md"
 license = "Apache-2.0"
 version.workspace = true
 edition = "2021"
-rust-version = "1.74"
+rust-version.workspace = true
 
 [dependencies]
 stellar-xdr = { workspace = true, features = ["curr", "std", "serde"] }

diff --git a/soroban-token-sdk/Cargo.toml b/soroban-token-sdk/Cargo.toml
@@ -8,7 +8,7 @@ readme = "../README.md"
 license = "Apache-2.0"
 version.workspace = true
 edition = "2021"
-rust-version = "1.74"
+rust-version.workspace = true
 
 [lib]
 crate-type = ["cdylib", "rlib"]

diff --git a/tests/add_i128/Cargo.toml b/tests/add_i128/Cargo.toml
@@ -5,7 +5,7 @@ authors = ["Stellar Development Foundation <[email protected]>"]
 license = "Apache-2.0"
 edition = "2021"
 publish = false
-rust-version = "1.74"
+rust-version.workspace = true
 
 [lib]
 crate-type = ["cdylib"]

diff --git a/tests/add_u128/Cargo.toml b/tests/add_u128/Cargo.toml
@@ -5,7 +5,7 @@ authors = ["Stellar Development Foundation <[email protected]>"]
 license = "Apache-2.0"
 edition = "2021"
 publish = false
-rust-version = "1.74"
+rust-version.workspace = true
 
 [lib]
 crate-type = ["cdylib"]

diff --git a/tests/add_u64/Cargo.toml b/tests/add_u64/Cargo.toml
@@ -5,7 +5,7 @@ authors = ["Stellar Development Foundation <[email protected]>"]
 license = "Apache-2.0"
 edition = "2021"
 publish = false
-rust-version = "1.74"
+rust-version.workspace = true
 
 [lib]
 crate-type = ["cdylib"]

diff --git a/tests/alloc/Cargo.toml b/tests/alloc/Cargo.toml
@@ -5,7 +5,7 @@ authors = ["Stellar Development Foundation <[email protected]>"]
 license = "Apache-2.0"
 edition = "2021"
 publish = false
-rust-version = "1.74"
+rust-version.workspace = true
 
 [lib]
 crate-type = ["cdylib"]

diff --git a/tests/auth/Cargo.toml b/tests/auth/Cargo.toml
@@ -5,7 +5,7 @@ authors = ["Stellar Development Foundation <[email protected]>"]
 license = "Apache-2.0"
 edition = "2021"
 publish = false
-rust-version = "1.74"
+rust-version.workspace = true
 
 [lib]
 crate-type = ["cdylib"]

diff --git a/tests/contract_data/Cargo.toml b/tests/contract_data/Cargo.toml
@@ -4,7 +4,7 @@ version.workspace = true
 authors = ["Stellar Development Foundation <[email protected]>"]
 license = "Apache-2.0"
 edition = "2021"
-rust-version = "1.74"
+rust-version.workspace = true
 publish = false
 
 [lib]

diff --git a/tests/empty/Cargo.toml b/tests/empty/Cargo.toml
@@ -5,7 +5,7 @@ authors = ["Stellar Development Foundation <[email protected]>"]
 license = "Apache-2.0"
 edition = "2021"
 publish = false
-rust-version = "1.74"
+rust-version.workspace = true
 
 [lib]
 crate-type = ["cdylib"]

diff --git a/tests/empty2/Cargo.toml b/tests/empty2/Cargo.toml
@@ -5,7 +5,7 @@ authors = ["Stellar Development Foundation <[email protected]>"]
 license = "Apache-2.0"
 edition = "2021"
 publish = false
-rust-version = "1.74"
+rust-version.workspace = true
 
 [lib]
 crate-type = ["cdylib"]

diff --git a/tests/errors/Cargo.toml b/tests/errors/Cargo.toml
@@ -5,7 +5,7 @@ authors = ["Stellar Development Foundation <[email protected]>"]
 license = "Apache-2.0"
 edition = "2021"
 publish = false
-rust-version = "1.74"
+rust-version.workspace = true
 
 [lib]
 crate-type = ["cdylib"]

diff --git a/tests/events/Cargo.toml b/tests/events/Cargo.toml
@@ -5,7 +5,7 @@ authors = ["Stellar Development Foundation <[email protected]>"]
 license = "Apache-2.0"
 edition = "2021"
 publish = false
-rust-version = "1.74"
+rust-version.workspace = true
 
 [lib]
 crate-type = ["cdylib"]

diff --git a/tests/fuzz/Cargo.toml b/tests/fuzz/Cargo.toml
@@ -5,7 +5,7 @@ authors = ["Stellar Development Foundation <[email protected]>"]
 license = "Apache-2.0"
 edition = "2021"
 publish = false
-rust-version = "1.74"
+rust-version.workspace = true
 
 [lib]
 # Adding rlib is required so that the test_fuzz crate can be imported as a

diff --git a/tests/import_contract/Cargo.toml b/tests/import_contract/Cargo.toml
@@ -5,7 +5,7 @@ authors = ["Stellar Development Foundation <[email protected]>"]
 license = "Apache-2.0"
 edition = "2021"
 publish = false
-rust-version = "1.74"
+rust-version.workspace = true
 
 [lib]
 crate-type = ["cdylib"]

diff --git a/tests/invoke_contract/Cargo.toml b/tests/invoke_contract/Cargo.toml
@@ -5,7 +5,7 @@ authors = ["Stellar Development Foundation <[email protected]>"]
 license = "Apache-2.0"
 edition = "2021"
 publish = false
-rust-version = "1.74"
+rust-version.workspace = true
 
 [lib]
 crate-type = ["cdylib"]

diff --git a/tests/logging/Cargo.toml b/tests/logging/Cargo.toml
@@ -5,7 +5,7 @@ authors = ["Stellar Development Foundation <[email protected]>"]
 license = "Apache-2.0"
 edition = "2021"
 publish = false
-rust-version = "1.74"
+rust-version.workspace = true
 
 [lib]
 crate-type = ["cdylib"]

diff --git a/tests/multiimpl/Cargo.toml b/tests/multiimpl/Cargo.toml
@@ -5,7 +5,7 @@ authors = ["Stellar Development Foundation <[email protected]>"]
 license = "Apache-2.0"
 edition = "2021"
 publish = false
-rust-version = "1.74"
+rust-version.workspace = true
 
 [lib]
 crate-type = ["cdylib"]

diff --git a/tests/udt/Cargo.toml b/tests/udt/Cargo.toml
@@ -5,7 +5,7 @@ authors = ["Stellar Development Foundation <[email protected]>"]
 license = "Apache-2.0"
 edition = "2021"
 publish = false
-rust-version = "1.74"
+rust-version.workspace = true
 
 [lib]
 crate-type = ["cdylib"]

diff --git a/tests/workspace_contract/Cargo.toml b/tests/workspace_contract/Cargo.toml
@@ -5,7 +5,7 @@ authors = ["Stellar Development Foundation <[email protected]>"]
 license = "Apache-2.0"
 edition = "2021"
 publish = false
-rust-version = "1.74"
+rust-version.workspace = true
 
 [lib]
 crate-type = ["cdylib"]

diff --git a/tests/workspace_lib/Cargo.toml b/tests/workspace_lib/Cargo.toml
@@ -5,7 +5,7 @@ authors = ["Stellar Development Foundation <[email protected]>"]
 license = "Apache-2.0"
 edition = "2021"
 publish = false
-rust-version = "1.74"
+rust-version.workspace = true
 
 [lib]
 crate-type = ["rlib"]