Skip to content

Commit

Permalink
Don't block merges on rust-analyzer compat check (#1151)
Browse files Browse the repository at this point in the history
### What
Don't block merges on rust-analyzer compat check.

### Why
It's been more than 6 months I think since we broke this compat check.
We might not need it anymore. We just don't seem to be stumbling upon
limitations in rust-analyzer, we might mean the things we were stumbling
on in the past have been fixed. We could remove it. Simply stopping it
from blocking merges is a step towards doing that.

Related:
- stellar/rs-soroban-env#1204
  • Loading branch information
leighmcculloch authored Nov 15, 2023
1 parent f70ac78 commit da0dc1c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:

complete:
if: always()
needs: [fmt, check-git-rev-deps, rust-analyzer-compat, build-and-test, docs]
needs: [fmt, check-git-rev-deps, build-and-test, docs]
runs-on: ubuntu-latest
steps:
- if: contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled')
Expand Down

0 comments on commit da0dc1c

Please sign in to comment.