Remove rust-analyzer-compat ci check (#1291)

### What

Remove rust-analyzer-compat ci check.

### Why

We added this when we seemed to be frequently breaking rust-analyzer
which slowed down dev envs for devs. But it's been more than 1 year
since I've seen anything break rust-analyzer. RA continues to get
better, and I don't think we need to keep running this check. There have
been at times problems with the check, although not frequent, it's part
of our process that isn't serving the need it was created for any
longer.

### Known limitations

[TODO or N/A]

.github/workflows/rust.yml

@@ -48,15 +48,6 @@ jobs:
     - uses: actions/checkout@v3
     - uses: stellar/actions/rust-check-git-rev-deps@main
 
-  rust-analyzer-compat:
-    runs-on: ubuntu-latest
-    steps:
-    - uses: actions/checkout@v3
-    - run: rustup update
-    - run: rustup +nightly component add rust-analyzer
-    - name: Check if rust-analyzer encounters any errors parsing project
-      run: rustup run nightly rust-analyzer analysis-stats . 2>&1 | (! grep '^\[ERROR')
-
   semver-checks:
     runs-on: ubuntu-latest
     steps: