Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to removal of ConversionError from number type conversions. #1083

Merged
merged 4 commits into from
Sep 9, 2023

Conversation

graydon
Copy link
Contributor

@graydon graydon commented Sep 8, 2023

This contains small fixes to adapt to changes to the env found during code review to eliminate easy-to-adapt-to uses of ConversionError (as described in bug stellar/rs-soroban-env#1046) where we can do better and pass a full Error.

@graydon graydon enabled auto-merge September 9, 2023 00:03
@graydon graydon added this pull request to the merge queue Sep 9, 2023
Merged via the queue into main with commit 1def3c6 Sep 9, 2023
14 checks passed
@graydon graydon deleted the adapt-to-errors-better-than-conversion-error branch September 9, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants