-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/new client with headers #13
Conversation
0fd159b
to
a4b0a92
Compare
c9c5a95
to
a4b0a92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One ask, otherwise I think this is good as is.
It seems that the Should we wait until protocol 22 to merge in the accompanying CLI PR? Or, does it make sense to have this PR target |
@janewang What's the urgency on API support? If we can delay on API support, I'd rather keep backports at this point to patch releases fixing bugs, rather than new features, just to reduce the divergence in code that we have to manage. But if API key support is urgent then lets target v21 here, and we can backport the CLI change. |
@leighmcculloch The API support change can wait for v22. It's asked by the community but I think it could wait for a few weeks |
@leighmcculloch @janewang, sounds good to delay support for this until v22. I'll make sure to keep this branch up-to-date with |
Actually, I suppose that means we can merge this in now - does that sound right @leighmcculloch ? |
Co-authored-by: Willem Wyndham <[email protected]>
What
Adds the ability to pass in headers to the HTTP client that is created in this client.
Companion cli PR: stellar/stellar-cli#1618
Why
Closes stellar/stellar-cli#1583
In order to allow for passing in headers to rpc providers, we need to build the HTTP client used in this client to include those headers.
Known limitations
N/A