Add fn for running the root cli command #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add fn for running the root cli command.
Why
For embedding into the soroban-cli. The best way to embed the XDR CLI is to reuse the type structures, which we can do, however the internals of the Root command are private and so there's no way to use the XDR CLI Root once parsing by clap is complete.
We could do two things, expose the fields as public, or expose the run behavior that already exists in this lib. Given the goal is to replicate behavior, exposing the existing run function seemed like the appropriate way to solve this problem.
Close stellar/stellar-cli#1018
Releasing
This change is intended for releasing as a patch release then propagating through the env and sdk repos such that the following change could be released:
Even though this change is intended as a patch release this repo has no changes existing or planned on main and since the last release and so this change is targeting main and the patch release will be made from there.