Take cheaper-instantiation XDR #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graydon
force-pushed
the
cheaper-instantiation
branch
from
7079b90 to
579b5be
Compare
7 tasks
graydon
force-pushed
the
cheaper-instantiation
branch
4 times, most recently
from
afb7533 to
e5af69d
Compare
graydon
force-pushed
the
cheaper-instantiation
branch
2 times, most recently
from
2128711 to
11bca74
Compare
graydon
force-pushed
the
cheaper-instantiation
branch
from
11bca74 to
5edb037
Compare
graydon
force-pushed
the
cheaper-instantiation
branch
from
ef61624 to
8892476
Compare
sisuresh
approved these changes
Mar 22, 2024
github-merge-queue bot
pushed a commit
to stellar/rs-soroban-env
that referenced
this pull request
Mar 26, 2024
This is a sketch of the first step in the plan for addressing #1292 and eventually #827 and #1313, namely: - add a bunch of cost types that decompose the current "worst case" VM instantiation cost type - continue to charge the worst case on initial contract upload - _store_ the decomposed cost-type inputs in the ledger, since we can observe them after the initial upload parse - _use_ those decomposed cost-type inputs when doing runtime instantiation - add a module cache - populate the module cache with all modules on host startup - use cached modules during instantiation This PR has accompanying changes in XDR and wasmi: - stellar/stellar-xdr#177 - stellar/rs-stellar-xdr#346 Remaining to do: - [x] determine what the correct set of decomposed cost types even is - [ ] ~add more code to wasmi to enable observing more inputs~ - [x] add cost-type runners / calibrations for all the decomposed cost-types - [x] protocol-gate this new behaviour - [x] make the linker-loop do less work to match the tighter cost model (i.e. complete #1292) - [x] possibly _duplicate_ the set of cost types added here, so we have a cached and uncached version of each, and implement a solution to #827 - [ ] possibly decompose the set sufficiently to model what will happen when we take wasmi 0.32 and enable lazy translation (i.e. complete #1313)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in support of stellar/rs-soroban-env#1359 -- see that PR for explanation and links to underlying bugs.