Support encoding streams in the cli #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisuresh
approved these changes
Aug 29, 2024
| @@ -96,6 +96,9 @@ impl Default for InputFormat { | |||
| pub enum OutputFormat { | |||
| Single, | |||
| SingleBase64, | |||
| Stream, | |||
| // TODO: StreamBase64, | |||
There was a problem hiding this comment.
Do we need to open issues for these?
There was a problem hiding this comment.
We could, but there is no pressing need for these things. So I think leaving the TODOs here as a way to signal if that feature is added here's the area to add it is okay. But I can also remove the TODOs too.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Support encoding streams in the cli.
Why
So that it is possible to pipe streams of XDR values to the CLI encode command and get out a stream of encoded XDR. Useful for building valid contract spec entries for WASMs using JSON.
You might also notice that stream base64 format is not supported for outputting. It would require more significant refactoring of this area of code to support that, and nothing in this PR does anything new to preclude doing that in the future, so I'm deferring it since I don't need it in this moment.
Dependent on: