Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update for preview 11 #136

Merged
merged 4 commits into from
Oct 6, 2023
Merged

build: update for preview 11 #136

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ceb40b8
build: update for preview 11
chadoh Sep 19, 2023
aa5cb01
build: fix CI config
chadoh Sep 20, 2023
c77fdf3
build: use updated quickstart image and --local flag
chadoh Sep 24, 2023
7ac27a3
fix: use newest quickstart
willemneal Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .cargo/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# paths = ["/path/to/override"] # path dependency overrides

[alias] # command aliases
install_soroban = "install --git https://github.com/stellar/soroban-tools --rev cb3c44f9d8080917a7cb019d6be25019f6cf78c3 --root ./target soroban-cli --debug"
install_soroban = "install --git https://github.com/AhaLabs/soroban-tools --rev dc2a543993a293155516df52e79cc120cbd3dfe0 --root ./target soroban-cli --debug"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this use https://github.com/stellar/soroban-tools --rev 20.0.0-rc2 or is there a branch on your fork that needs to be merged back to stellar/soroban-tools?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, there's a branch (stellar/stellar-cli#973), see PR description.

This branch is waiting on a quickstart that works with preview 11 + standalone.

The lack of such a quickstart is probably also the cause of your troubles running this on standalone.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see, you are referring to the stellar/quickstart:soroban-dev docker image? yes, it's been recently published for preview11 as stellar/quickstart:testing@sha256:1c98f895f8b69cc843eeaa5230d67044dbeb390a5529d51dd7762d8ff685c3f8

b = "build --target wasm32-unknown-unknown --release"
# c = "check"
# t = "test"
Expand Down
8 changes: 5 additions & 3 deletions .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,11 @@ jobs:
- run: |
mkdir -p .soroban-example-dapp
echo 'futurenet' > .soroban-example-dapp/network
echo 'CC757WDV3G442WQCNPNOA2UEXOC7UJD5VP4BLLCRDW5LRM6UZZR6ISVU' > .soroban-example-dapp/abundance_token_id
echo 'CCHCPXECLYGX4QU34ZZOHP6C6KVAPIDTUNPIUA6GF4SP6ECFF5BX57OG' > .soroban-example-dapp/crowdfund_id
echo 'Standalone Network ; February 2017' > .soroban-example-dapp/passphrase
echo 'CAU23MVDEW7VMB3AXC5PL5GZO3HBYZPEIP2P46X4T3AIC4Y7FXYZWES5' > .soroban-example-dapp/abundance_token_id
echo 'CDJPYH5HNGZ24SEWXFJOW6RXXHHNKU4XPCPBMB2VRTDPTMVPLYFQKZIE' > .soroban-example-dapp/crowdfund_id
echo 'Test SDF Future Network ; October 2022' > .soroban-example-dapp/passphrase
echo 'https://rpc-futurenet.stellar.org/' > .soroban-example-dapp/rpc-url
echo '{"network":"futurenet","rpcUrl":"https://rpc-futurenet.stellar.org","networkPassphrase":"Test SDF Future Network ; October 2022"}' > shared/config.json

- run: npm ci
- run: npm run build
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# See https://help.github.com/articles/ignoring-files/ for more about ignoring files.
/.soroban-example-dapp
/.soroban
/shared/config.json
# dependencies
/node_modules
/.pnp
Expand Down
Loading