Skip to content

Commit

Permalink
Fix: Make Dockerhub publish dependent on npm publish (#123)
Browse files Browse the repository at this point in the history
Currently, there is a race where the Dockerhub publish completes before
the npm one does, causing the image to use the older version of the test
package.

Reference: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_run
  • Loading branch information
philipliu authored Oct 5, 2023
1 parent cf47531 commit f58851c
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/docker_publish.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
name: docker image publish
on:
release:
types: [published]
workflow_run:
workflows: ["npm publish"]
branches: [main]
types:
- completed

jobs:
build_and_push_docker_image:
Expand Down

0 comments on commit f58851c

Please sign in to comment.