Skip to content

Commit

Permalink
Add cargo-deny for license checks and dep duplicate avoidance (#1685)
Browse files Browse the repository at this point in the history
  • Loading branch information
leighmcculloch authored Nov 6, 2024
1 parent 1fc9c34 commit 0b4c363
Show file tree
Hide file tree
Showing 4 changed files with 326 additions and 21 deletions.
15 changes: 14 additions & 1 deletion .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:

complete:
if: always()
needs: [fmt, check-generated-full-help-docs, build-and-test, publish-dry-run]
needs: [fmt, cargo-deny, check-generated-full-help-docs, build-and-test, publish-dry-run]
runs-on: ubuntu-latest
steps:
- if: contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled')
Expand All @@ -30,6 +30,19 @@ jobs:
- run: rustup update
- run: cargo fmt --all --check

cargo-deny:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
check: [advisories, bans, licenses, sources]
continue-on-error: ${{ matrix.check == 'advisories' || matrix.check == 'bans' || matrix.check == 'licenses' }}
steps:
- uses: actions/checkout@v3
- uses: EmbarkStudios/cargo-deny-action@b01e7a8cfb1f496c52d77361e84c1840d8246393
with:
command: check ${{ matrix.check }}

check-generated-full-help-docs:
runs-on: ubuntu-latest-16-cores
steps:
Expand Down
38 changes: 19 additions & 19 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion cmd/crates/stellar-ledger/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ version.workspace = true
edition = "2021"
rust-version.workspace = true

# This crate has not yet ever been published. Skip publishing until these
# security issues are addressed:
# https://github.com/stellar/stellar-cli/issues/1706
publish = false

[dependencies]
soroban-spec = { workspace = true }
thiserror = "1.0.32"
Expand Down Expand Up @@ -47,7 +52,7 @@ once_cell = "1.19.0"
pretty_assertions = "1.2.1"
serial_test = "3.0.0"
httpmock = "0.7.0-rc.1"
test-case = "*"
test-case = "3.3.1"
testcontainers = "0.20.1"


Expand Down
Loading

0 comments on commit 0b4c363

Please sign in to comment.