Skip to content

Commit

Permalink
update test deltas for preflight
Browse files Browse the repository at this point in the history
  • Loading branch information
mollykarcher committed Jan 6, 2024
1 parent 535e4f1 commit 165628c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions cmd/soroban-rpc/internal/test/simulate_transaction_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ func TestSimulateTransactionSucceeds(t *testing.T) {
assert.InDelta(t, uint32(expectedTransactionData.Resources.Instructions), uint32(transactionData.Resources.Instructions), 3200000)
assert.InDelta(t, uint32(expectedTransactionData.Resources.ReadBytes), uint32(transactionData.Resources.ReadBytes), 10)
assert.InDelta(t, uint32(expectedTransactionData.Resources.WriteBytes), uint32(transactionData.Resources.WriteBytes), 300)
assert.InDelta(t, int64(expectedTransactionData.ResourceFee), int64(transactionData.ResourceFee), 3000)
assert.InDelta(t, int64(expectedTransactionData.ResourceFee), int64(transactionData.ResourceFee), 4000)

// Then decode and check the result xdr, separately so we get a decent diff if it fails.
assert.Len(t, result.Results, 1)
Expand Down Expand Up @@ -1125,7 +1125,7 @@ func TestSimulateSystemEvent(t *testing.T) {
err = xdr.SafeUnmarshalBase64(response.TransactionData, &transactionData)
require.NoError(t, err)

assert.InDelta(t, 7464, uint32(transactionData.Resources.ReadBytes), 200)
assert.InDelta(t, 7464, uint32(transactionData.Resources.ReadBytes), 600)
// the resulting fee is derived from compute factors and a default padding is applied to instructions by preflight
// for test purposes, the most deterministic way to assert the resulting fee is expected value in test scope, is to capture
// the resulting fee from current preflight output and re-plug it in here, rather than try to re-implement the cost-model algo
Expand Down

0 comments on commit 165628c

Please sign in to comment.