Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keys: add does not validate keys #1805

Open
leighmcculloch opened this issue Dec 19, 2024 · 0 comments · May be fixed by #1812
Open

keys: add does not validate keys #1805

leighmcculloch opened this issue Dec 19, 2024 · 0 comments · May be fixed by #1812
Assignees
Labels
bug Something isn't working

Comments

@leighmcculloch
Copy link
Member

The stellar keys add <name> --seed-phrase command accepts a seed phrase, but does not validate it.

You can pass it an 11 word phrase, or a malformed string, and it'll accept it.

For example, you can enter gibberish:

$ stellar keys add a4 --seed-phrase
Type a 12 word seed phrase: 
asdflkjaslkdfjklasdjflk
$ cat ~/.stellar/identity/a4.toml
seed_phrase = "asdflkjaslkdfjklasdjflk"

The add command when used with the seed phrase should only allow entering a valid 12 or 24 word key phrase.

@leighmcculloch leighmcculloch added the bug Something isn't working label Dec 19, 2024
@github-project-automation github-project-automation bot moved this to Backlog (Not Ready) in DevX Dec 19, 2024
@leighmcculloch leighmcculloch self-assigned this Dec 19, 2024
leighmcculloch added a commit that referenced this issue Dec 19, 2024
@leighmcculloch leighmcculloch linked a pull request Dec 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog (Not Ready)
Development

Successfully merging a pull request may close this issue.

1 participant