keys: valid keys when added #1812
Conversation
leighmcculloch
changed the title
| #[error(transparent)] | ||
| Signer(#[from] signer::Error), | ||
| } | ||
|
|
||
| #[derive(Debug, clap::Args, Clone)] | ||
| #[group(skip)] | ||
| pub struct Args { | ||
| /// Add using `secret_key` | ||
| /// (deprecated) Add secret (S) key |
There was a problem hiding this comment.
Ah so we will just have a secret in the future? If so could we add it here? It seems weird to deprecate without an alternative.
There was a problem hiding this comment.
I think we can accept both as inputs without using any options. Wdyt?
There was a problem hiding this comment.
This change seems like it simplifies things!
I wonder if a bit more explanation in the doc comments & deprecations would help to let the user know that they will now be prompted to enter their key/passphrase. I was a bit confused at first how this would work, until I tried it out.
Something like this maybe?
| /// (deprecated) Add secret (S) key | |
| /// (deprecated) Enter secret (S) key when prompted |
Co-authored-by: Willem Wyndham <[email protected]>
| #[error(transparent)] | ||
| Signer(#[from] signer::Error), | ||
| } | ||
|
|
||
| #[derive(Debug, clap::Args, Clone)] | ||
| #[group(skip)] | ||
| pub struct Args { | ||
| /// Add using `secret_key` | ||
| /// (deprecated) Add secret (S) key |
There was a problem hiding this comment.
This change seems like it simplifies things!
I wonder if a bit more explanation in the doc comments & deprecations would help to let the user know that they will now be prompted to enter their key/passphrase. I was a bit confused at first how this would work, until I tried it out.
Something like this maybe?
| /// (deprecated) Add secret (S) key | |
| /// (deprecated) Enter secret (S) key when prompted |
What
Validate secret keys and seed phrases when adding.
Why
Close #1805