fix(CLI): ensuring that read ledger entries match up with ledger keys #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@willemneal I'm not sure if this would be needed in light of #916. What do you think ? |
Merged
|
@leighmcculloch I think that #916 conflicts with this one. |
|
close in favor of #1021 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Previously it was assumed that
<key1, key1_expiration>returned with<LedgerEntry_1, LedgerEntry_expiration>, but this isn't always the case and it was causing flaky tests.Why
This PR ensures that the ledger keys are matched with their expiration. This allows any ordered returned from the RPC.
Known limitations
[TODO or N/A]