-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(CLI): update xdr and bump -> extend #1031
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update. * preserve cors behaviour * update version
willemneal
force-pushed
the
fix/cli/extend
branch
from
October 18, 2023 18:03
431ff25
to
fafe288
Compare
2opremio
reviewed
Oct 19, 2023
2opremio
reviewed
Oct 19, 2023
Looking good! Did you remove all references to bump/expire? (both in publicly exposed stuff and code symbols) What I did in the rpc was grepping for |
* feat!: remove run_in_sandbox * fix: reorganize tests that rely on network and ignore outside of go test * fix: use feature instead of cfg so that cargo test --list can find tests * fix: move common tests to single functions to skip setup time * feat!: skip wasm in invoke * fix: fully remove all sandbox related types and args
willemneal
force-pushed
the
fix/cli/extend
branch
from
October 19, 2023 16:25
6fa68ec
to
e262830
Compare
willemneal
force-pushed
the
fix/cli/extend
branch
from
October 20, 2023 14:40
ebaace6
to
62a3c57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.