feat: create soroban-rpc and break up send_transaction to fix not always submitting a transaction. #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willemneal
force-pushed
the
cli/fix/view
branch
2 times, most recently
from
f2bbcd5 to
746a350
Compare
willemneal
force-pushed
the
cli/fix/view
branch
2 times, most recently
from
319076f to
01a7ca4
Compare
willemneal
force-pushed
the
cli/fix/view
branch
from
79807d3 to
fea8d06
Compare
willemneal
changed the title
willemneal
force-pushed
the
cli/fix/view
branch
from
3ec6faf to
c7d9774
Compare
| @@ -0,0 +1,59 @@ | |||
| [package] | |||
| name = "soroban-rpc" | |||
There was a problem hiding this comment.
I have pushed an empty crate to crates.io for this crate from the stellar-crates user so that we know we can use it and its ready to go.
willemneal
force-pushed
the
cli/fix/view
branch
3 times, most recently
from
97a8db8 to
bf12cc0
Compare
mollykarcher
added
cli
willemneal
force-pushed
the
cli/fix/view
branch
2 times, most recently
from
c9ed9b2 to
e28f98b
Compare
stellarsaur
approved these changes
Jan 9, 2024
| @@ -0,0 +1,3 @@ | |||
| # soroban-rpc | |||
|
|
|||
| Tools and utilities for soroban rpc. | |||
There was a problem hiding this comment.
Would be ideal to have a more comprehensive README but this is fine to get the crate created/published
| @@ -61,26 +61,52 @@ rev = "822ce6cc3e461ccc925275b472d77b6ca35b2cd9" | |||
| version = "20.0.2" | |||
| path = "cmd/soroban-cli" | |||
|
|
|||
| [workspace.dependencies.soroban-rpc] | |||
| version = "20.0.0-rc4" | |||
There was a problem hiding this comment.
Should this be updated now that 20.1.1 is released?
|
Thanks for taking this on! Please resolve merge conflicts and make sure all tests are passing and we can get this merged. |
willemneal
force-pushed
the
cli/fix/view
branch
from
e28f98b to
2c65160
Compare
This allows for logging transaction data including budgets/costs for later inspection.
willemneal
force-pushed
the
cli/fix/view
branch
from
2c65160 to
89b3315
Compare
13 tasks
|
in lieu of #1174 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a new crate for the RPC which is been a long time coming. Perhaps this crate and the go rpc could move to a separate repo. But either way it makes it clearer when the rpc is updated and allowing for updates to the rpc without updating the CLI's dep.
There is some response parsing done by subcommands that could move to the rpc, but this change is minimal to the current RPC API.