chore: don't force rebuild during build-test-wasms #1073
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I agree with the change. I'm somewhat confused why we're even manually calling cargo update since most cargo commands should do this as part of the typical work. So I'd be curious if we could pull it out entirely, but would like to hear from @2opremio @mollykarcher and other platform folks what the problem being solved is.
|
@leighmcculloch I think the rebuild might be caused by the |
chadoh
force-pushed
the
chore/test-wasms-no-rebuild
branch
from
5443e3c to
4bf2933
Compare
|
@chadoh I'm going to look into this today. |
|
Resolved in a Discord discussion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove the
Cargo.lockprereq from thebuild-test-wasmstask and thecheckfrom theall:directiveWhy
I don't see a good reason to include these, and they cause most tasks to take significantly longer to run. If there's no strong reason to include them, then it would be nice to save the build time.
Known limitations
These were originally added here #251 and here 0c51782. I don't see a description of why these particular changes were added.