Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soroban-rpc: Ensure that the key corresponds to the value in getLedgerEntries #1085

Closed
wants to merge 1 commit into from
Closed

soroban-rpc: Ensure that the key corresponds to the value in getLedgerEntries #1085

wants to merge 1 commit into from

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Nov 15, 2023

What

Encodes the key alongside the value because request.Keys[i] may not always match it.

Why

It should fix #1084.

Known limitations

It's not tested because it's a bit of a Heisenbug (more accurately, it's non-deterministic).

@Shaptic Shaptic requested a review from 2opremio November 15, 2023 22:03
@2opremio
Copy link
Contributor

Thanks! I am sure this works but it's less efficient and it would be good to find out why request.Keys[i] doesn't match the entry

@2opremio
Copy link
Contributor

I will look into it

@2opremio
Copy link
Contributor

@Shaptic I created #1093 which should override this PR

@Shaptic Shaptic closed this Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2opremio 2opremio Awaiting requested review from 2opremio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shaptic @2opremio