feat!: move config commands to top level

[willemneal]

What

• fixes soroban-cli: uses the same identity/account/key for everybody by default #1079
• fixes soroban-cli: move config * commands to top level #1054
• fixes soroban-cli: rename config identity to config key #1053
• fixes soroban-cli: refers to 'stellar asset contract' as 'token' #934
  • contract asset was added with deploy and id subcommands.
  • Initially contract deploy had two subcommands wasm and asset, but this was a breaking change and it was hard to have clap allow deploy without a subcommand to default to wasm. So perhaps we will add this when introducing breaking changes.
• Removed xdr subcommand, but will address later. soroban-cli: replace lab xdr subcommand with embedding the stellar-xdr cli #1018

Why

[TODO: Why this change is being made. Include any context required to understand the why.]

Known limitations

[TODO or N/A]

[willemneal]

@leighmcculloch The last step is to split identity into keys and address book. Should I put them under the network too?

That is store them in a folder for each network?

[leighmcculloch]

I thought the identity command today was just keys that have a secret, not address only identities. I don't think we need to add the address book now if so.

[leighmcculloch]

That is store them in a folder for each network?

I'm concerned that separating keys by network in the CLI UI will create for a confusing or unintuitive interface. I think we should do some UI design in a doc before embarking on it in code.

[willemneal]

Yeah the addresses become tricky because contract id's are derived from the network passsphrase and are obviously only deployed on one network. So we could keep keys as is and add the address book per network. But either way I'll just update this PR to just rename identity to keys.

[willemneal]

@2opremio Looks like the prefight debug test is failing:

=== RUN   TestGetPreflightDebug
    preflight_test.go:388: 
                Error Trace:    /Users/willem/c/s/soroban-cli/cmd/soroban-rpc/internal/preflight/preflight_test.go:388
                Error:          "host invocation failed\n\nCaused by:\n    HostError: Error(WasmVm, MissingValue)\n    DebugInfo not available\n    " does not contain "Backtrace"

[janewang]

Food for thought, and not this PR. Would be nice to be able view accounts in a table-like view with its respective network futurenet|testnet|mainnet

Network Name Public key 
─────── ──── ─────── 
testnet alice G-
testnet bob G-

[2opremio]

@2opremio Looks like the prefight debug test is failing:

=== RUN   TestGetPreflightDebug
    preflight_test.go:388: 
                Error Trace:    /Users/willem/c/s/soroban-cli/cmd/soroban-rpc/internal/preflight/preflight_test.go:388
                Error:          "host invocation failed\n\nCaused by:\n    HostError: Error(WasmVm, MissingValue)\n    DebugInfo not available\n    " does not contain "Backtrace"

Uhm, can you try to debug it? I am off this week. Thanks!

[leighmcculloch]

cc @stellarsaur Is this something you able to help with?

[willemneal]

Food for thought, and not this PR. Would be nice to be able view accounts in a table-like view with its respective network futurenet|testnet|mainnet

Network Name Public key 
─────── ──── ─────── 
testnet alice G-
testnet bob G-

I agree, but we currently don't store keys under their network so it's not possible. So I'll make a future PR that addresses this.

[willemneal]

error: There are multiple stellar-xdr packages in your project, and the specification stellar-xdr is ambiguous

I purposely depended on the stellar-xdr repo at a different version in the soroban-cli crate to get access to thecil feature. When I initially updated the version at the top level it broke other crates. I can either update the whole workspace to the newest xdr and then merge the xdr CLI stuff or we can ignore this for now?

I vote for shelving the xdr cli until the whole workspace is updated to the newest stellar-xdr, as it doesn't make sense that the rest of the workspace has a different version.

[leighmcculloch]

There's no need to ship embedding the xdr CLI right now. It's not urgent. There's an issue open tracking that work separately:

• soroban-cli: replace lab xdr subcommand with embedding the stellar-xdr cli #1018

[willemneal]

@leighmcculloch @mollykarcher

The CI dep checker failed with just the following:

Error: Process completed with exit code 6.

[leighmcculloch]

Would be great to get this included in the next release, but a couple things:

1. Looks like there's one system test failing that might be important.

2. There are some minor conflicts before it can merge.

3. This change is a breaking change to the CLI's UI, and we've released v20 stable already, so can we add hidden subcommands, or subcommands marked as deprecated, into the old locations for the commands being moved/renamed so that anyone already using them will continue to be able to use them?

[janewang]

Let's make this change not breaking please #1146