all: Bump core, Rust dependencies #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamirms
force-pushed
the
update-deps
branch
3 times, most recently
from
8f66533 to
8860cb5
Compare
mollykarcher
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
we should make a follow-up issue to address what we want to do with the dependency script, possibly following the recommendation here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update core and the soroban rust libraries to the latest version so we can release soroban-rpc for the testnet reset.
Known limitations
There is a bug in the check dependencies script which is causing the "Dependency sanity checker" CI failure. The script relies on the fact that the git and rev properties would be supplied for the stellar-xdr dependency. However, those properties were commented out of the stellar-xdr dependency in the rs-soroban-env repo https://github.com/stellar/rs-soroban-env/blob/main/Cargo.toml#L31-L32 .
Also, we had to add a huge fudge factor to the fees calculated by the preflight library in order to get them to be comparable to how stellar-core calculates fees. The proper fix i to align the behavior of the preflight library with stellar-core but that will be handled after the testnet release.