build: make dependency-check script more verbose #1116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stellarsaur
approved these changes
Dec 8, 2023
|
@leighmcculloch mentioned in Slack that we need to remove this custom script and use cargo-deny as in other repos; I think he was working on that? |
|
I'm not working on it 😄. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add more printf and echo statements to the dependency-check script so we can figure out where it fails.
Why
Right now if something goes wrong it's really hard to tell what.
Known limitations
This branch should probably also fix whatever is causing the dependency-check script to fail on CI.