soroban-rpc: Remove panics from internal codebase #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sreuland
reviewed
Jan 12, 2024
sreuland
reviewed
Jan 12, 2024
2opremio
reviewed
Jan 16, 2024
cmd/soroban-rpc/internal/ledgerbucketwindow/ledgerbucketwindow.go
Outdated
Show resolved
Hide resolved
2opremio
approved these changes
Jan 22, 2024
elizabethengelman
pushed a commit
to AhaLabs/stellar-cli
that referenced
this pull request
Jan 31, 2024
* Remove panic - 1 * Remove panic - 2 * Remove panic - 3 * Remove panic - 4 * Small changes - 1 * undo changes in Get() func * undo changes - 2 * undo changes - 3 * add test for append error
2opremio
pushed a commit
that referenced
this pull request
Mar 26, 2024
* Remove panic - 1 * Remove panic - 2 * Remove panic - 3 * Remove panic - 4 * Small changes - 1 * undo changes in Get() func * undo changes - 2 * undo changes - 3 * add test for append error (cherry picked from commit b6671e2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #500
There are instances in soroban-rpc where the code will panic/exit from within. This PR fixes the code and returns error to main instead of exiting internally.
Why
Makes it easier to test the code and makes it consistent in handling errors.
Known limitations
NA