soroban-rpc: Add common retention window for events and transactions. #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psheth9
changed the title
|
I know it's still a draft, but we shouldn't merge this until we can gauge the storage implications of increasing the tx window to 24 hours. |
|
Yes agreed @2opremio !! I won't merge :) I think @stellarsaur already did some initial profiling here Do we also want to make sure that retention window should not go beyond 24hrs? or no such upper bound limitation here? cc @mollykarcher (not sure if we are doing that already) |
|
BTW, isn’t this a dup of #1060 ? |
|
If we don't think this will be merged by the end of this week, can we please close this PR and re-open it in the |
|
Closing since the rpc has moved to another repo, this change needs taking to that other repo if the change is still relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add a config for common retention window for events and transactions
Why
More detail here: stellar/stellar-rpc#15
Known limitations
[TODO or N/A]