Add events data to GetTransaction rpc #1192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psheth9
force-pushed
the
update-get-txn-with-events
branch
from
4b8e79e to
8dcb16a
Compare
|
Once ready for review, please close this PR and reopen in |
Shaptic
approved these changes
Feb 8, 2024
| @@ -198,10 +199,33 @@ func (m *MemoryStore) GetTransaction(hash xdr.Hash) (Transaction, bool, StoreRan | |||
| if !ok { | |||
| return Transaction{}, false, storeRange | |||
| } | |||
|
|
|||
| var tx_meta xdr.TransactionMeta | |||
There was a problem hiding this comment.
nit: style consistency so let's use camelCase
| return Transaction{}, false, storeRange | ||
| } | ||
|
|
||
| var events [][]byte |
There was a problem hiding this comment.
preallocate since we know the size?
Suggested change
| var events [][]byte | |
| events := make([]byte, 0, len(txEvents)) |
| tx, ok, _ := store.GetTransaction(txHash(1, false)) | ||
| require.True(t, ok) | ||
| require.NotNil(t, tx.Events) | ||
|
|
There was a problem hiding this comment.
length check (easier) or content check (harder) would be good here besides not-nil
|
Moving to soroban-rpc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details here --> stellar/stellar-rpc#16
Known limitations
NA