Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soroban-cli: Use soroban-rpc Crate from the RPC Repo #1195

Merged
merged 2 commits into from
Feb 13, 2024
Merged

soroban-cli: Use soroban-rpc Crate from the RPC Repo #1195

merged 2 commits into from
Feb 13, 2024

Conversation

stellarsaur
Copy link
Contributor

What

This PR gets the soroban-rpc crate from the soroban-rpc repo, instead of building locally.

Why

The soroban-rpc should be responsible for building & publishing this crate, not soroban-tools.

@stellarsaur stellarsaur marked this pull request as ready for review February 9, 2024 00:10
@stellarsaur stellarsaur requested a review from 2opremio February 9, 2024 00:10
@stellarsaur stellarsaur enabled auto-merge (squash) February 13, 2024 22:08
@stellarsaur stellarsaur merged commit 1b43428 into main Feb 13, 2024
25 of 26 checks passed
@stellarsaur stellarsaur deleted the rpc-crate branch February 13, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leighmcculloch leighmcculloch leighmcculloch approved these changes

@2opremio 2opremio Awaiting requested review from 2opremio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stellarsaur @leighmcculloch